GitLab

Because RT::Authen::ExternalAuth runs before core's
AttemptPasswordAuthentication, the core "you're logged in!" callback
never runs.  This means if you want to do something 'on login' you have
no hook for RT::Authen::ExternalAuth users.

We call the core SuccessfulLogin callback from RT::Authen::ExternalAuth
so that your code should 'just work' in both scenarios.

The DoAuth $next extraction is virtually identical to core, so should
work for normal use cases (RTIR's code works on both core and with this
change).

This condenses and updates the configuration options, as well as
providing them in one place.

Remove the documentation dealing with the no-longer-supported 3.4, 3.6,
and 3.8 releases.  Use the standard RT::Extension installation
instructions, as well as footer.  Condense the "MORE ABOUT THIS MODULE"
into the "DESCRIPTION" and de-duplicate, removing reference to the
no-longer-relevant RT::Authen::CookieAuth.

Plack::Handler::Apache2 removes $ENV{MOD_PERL}, to prevent some modules
(like CGI and CGI::Cookie) from looking in the wrong locations for
input.  Unfortunately, this has catastrophic results for the loading of
Net::SSLeay, which segfaults Apache if loaded under mod_ssl + mod_perl
without being able to detect it is running as such.

Remove the early loading of Net::SSLeay, and the entire
ExternalServiceUsesSSLorTLS argument in general.  There is no need to
load Net::SSLeay early, and no need for a configuration variable that
merely repeats what can be inferred from individual service
configurations.

Also add a repository link and update copyright

This continues on  33142349 where I caught this in the LDAP.pm docs,
which are an almost copy of these docs, but added bugs and missed
documenting things like attr_map or attr_match_list

Instead point out that it's an option, but also point out the problems.

As we note in the docs and in the config example, anything other than
Name and EmailAddress usually goes poorly.  I'm not sure why the
synopsis example (which is the thing most people will copy) is optimized
for failure.

ExternalSettings is a hashref because it predates widespread support
and knowledge of Set(%ExternalSettings,) and it gives a really crappy
message if you Set($ExternalSettings, MyLDAP =>
rather than Set($ExternalSettings, { MyLDAP

The previous INSERT in sessions.t inserted multiple rows
in one VALUES clause, a feature added to sqlite3 in 3.7.11. Change
to insert individual rows to avoid failures on systems
with older default sqlite installs like Mac OS 10.7 which has
version 3.7.7.

These were written on the docs-improvements branch and describe code
from the multiple-emails branch, which has not been merged.

Shipping these docs makes end users believe that this extension contains
code that it does not.

The docs have been moved to the tip of multiple-emails.  They will
re-enter when that branch is merged.

The id changes with the menu location, which changes in RT 4.2.

Not all configs may have a server, for example.

p_check should be a code reference that takes password's HASH
and password user entered, returns boolean that indicates whether
password is correct or not

MetaCPAN doesn't detect included documentation unless it has a NAME
matching the package.

Two nits noticed while skimming.