GitLab

The Object passed to EditCustomField should be the type the
custom field is applied to. Passing the queue object would only
be correct for queue cfs, which is not a typical case. For ticket
cfs, the typical case, passing the queue object creates an incorrect
name in the form and the cf isn't processed properly on submit.

EditCustomField can generate the correct form element from the
passed CustomField object.

This issue has likely not been noticed because the queue object is
only set when you pass it via 'notes'.

EmailInput already has a default Size value if it is not passed in -
currently at '40'. Deferring to that value allows for a more consistent
look to EmailInput elements created via FormTools without duplicating the
constant value (40).

Check exists $ARGS{cols} to allow for explicitly passing cols => undef,
which produces an input with no "size" set.

Provide convenience option to toggle on /Elements/Tabs for non
SelfService forms. Also document conditionals a bit and re-whitespace.

Add a bit more flexibility to FormTools/Form component. It is
desireable, in certain situations, to be able to set the 'name'
parameter of the form element.

Make it clear that we are clearing the context object that
had been set to global context. We aren't setting the context
to the ticket because in the final case where LoadByName
is called, $ticket is undef.

This workaround is only needed for RT 4.2.0 - 4.2.4. LoadByName
is refactored in 4.2.5 to correctly set the context object.

When attempting to load a CF, the code attempts to find a
global CF before loading by name alone. The LoadByName CF method
automatically sets the context object to global on that call,
so the subsequent call in Field doesn't find non-global CFs since
it is using the same CF object. Reset the context object to the
ticket so the name lookup can find non-global CFs.

FormTools creates tables for each form element it creates
and you sometimes want to add some text next to the label
that is not part of the label, like a link or footnote.
Likewise, you sometimes want to add some additional text after
the input field in the table created for the input.

This commit adds two configuration variables that can accept HTML to
add this additional text.

make it possible for selector to point directly at
a form field

make it possible to disable particular options

Textareas are just like large <input> fields.

Normal submit and reset buttons were already being disabled by catching
all <input> elements regardless of type, so include <button> elements
as well.

Although this is a behaviour change, hopefully no one was relying on the
this quirk of element selection.  If so, they can adjust their
containing elements appropriately.

This includes dropdowns and single or multiple pick boxes.

When render_as is readonly_plus_values, then add in the hidden inputs.

Make ARGS parameters look (arguably) "better".

If $queue is not defined, then this Mason component blows up. These
conditionals should catch that. Also perform generic Load for CF if
queue specific and global loads fail.

SelfService header includes some tabs and seems to circumvent the
PageLayout, so don't display PageLayout if using SelfService.

Conflicts:
	lib/RT/Extension/FormTools.pm

If 'form_id' is passed into the Form component, then have it show up as an
attribute in the html form element.