Fixing a deep recursion bug, a couple loc bugs

Makefile

@@ -22,7 +22,6 @@
 # 
 # 
 # END LICENSE BLOCK
-
 PERL			= 	/usr/bin/perl
 
 CONFIG_FILE_PATH	=	/opt/rt3/etc
@@ -32,7 +31,7 @@ GETPARAM		=	$(PERL) -e'require "$(CONFIG_FILE)"; print $${$$RT::{$$ARGV[0]}};'
 
 RT_VERSION_MAJOR	=	2
 RT_VERSION_MINOR	=	1
-RT_VERSION_PATCH	=	35
+RT_VERSION_PATCH	=	36
 
 RT_VERSION =	$(RT_VERSION_MAJOR).$(RT_VERSION_MINOR).$(RT_VERSION_PATCH)
 TAG 	   =	rt-$(RT_VERSION_MAJOR)-$(RT_VERSION_MINOR)-$(RT_VERSION_PATCH)

README

@@ -22,7 +22,6 @@
 # 
 # 
 # END LICENSE BLOCK
-
 WARNING
 -------
 

html/Admin/Elements/AddCustomFieldValue

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <&|/l&>SortOrder</&>: <input name="CustomField-<% $CustomField->Id %>-AddValue-SortOrder" size="5"><BR>
 <&|/l&>Name</&>: <input size=20 name="CustomField-<% $CustomField->Id %>-AddValue-Name"><BR>
 <&|/l&>Description</&>: <input size="60" name="CustomField-<% $CustomField->Id %>-AddValue-Description"><BR>

html/Admin/Elements/CreateQueueCalled

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <FORM METHOD=get ACTION="<% $RT::WebPath %>/Admin/Queues/Create.html">
 <&|/l&>Create a queue called</&> <INPUT NAME="Name" size=10><input type=submit>
 </form>

html/Admin/Elements/CreateUserCalled

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <FORM METHOD=get ACTION="<% $RT::WebPath %>/Admin/Users/Create.html">
 <&|/l&>New user called</&> <INPUT NAME="Name" size=10><input type=submit value="<&|/l&>Create</&>">
 </form>

html/Admin/Elements/EditCustomFieldValues

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <ul>
 % while (my $v = $values->Next) {
 <li>

html/Admin/Elements/EditQueueWatchers

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 %if ($Members->Count == 0 ) {
 <ul>
 <li><i>none</i>

html/Admin/Elements/EditScrip

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <& /Elements/ListActions, actions => \@actions &>
 
 <& /Elements/TitleBoxStart, title => $title &>
@@ -70,7 +69,7 @@
 <TD>
 <TEXTAREA COLS=80 ROWS=8 NAME="Scrip-<%$id%>-CustomPrepareCode"><%$scrip->CustomPrepareCode%></TEXTAREA>
 </TD>
-</TR/
+</TR>
 <TR>
 <TD ALIGN=RIGHT>
 <&|/l&>Custom action cleanup code</&>:

html/Admin/Elements/EditScrips

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <& /Elements/ListActions, actions => \@actions &>
 
 <form action="Scrips.html" method="post">

html/Admin/Elements/EditUserComments

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <& /Elements/Header, Title => "Comments about $name" &>
 <&|/l&>These comments aren't generally visible to the user</&>:<br>
 <input type="hidden" name="id" value="<%$id%>">

html/Admin/Elements/GrantQueueRightsTo

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <BR>
 
 % if ($msg) {

html/Admin/Elements/GroupTabs

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <& /Admin/Elements/Tabs, subtabs => $subtabs, current_tab => 'Admin/Groups/' &>
 <hr>
 <%INIT>

html/Admin/Elements/Header

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <& /Elements/Header, Title => $Title &>
 
 <%ARGS>

html/Admin/Elements/ListGlobalScrips

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 %  while (my $scrip = $Scrips->Next ) {
 <% $scrip->ConditionObj->Name %> 
 <% $scrip->ActionObj->Name %> 

html/Admin/Elements/ModifyQueue

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <& /Elements/TitleBoxStart, title => loc('Editing Configuration for queue [_1]', $QueueObj->Id) &>
 
 <FORM ACTION="<%$RT::WebPath%>/Admin/Queues/Modify.html" METHOD=POST>

html/Admin/Elements/ModifyTemplate

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <TABLE>
 <TR>
 <TD ALIGN=RIGHT>

html/Admin/Elements/ModifyUser

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <& /Elements/TitleBoxStart, title => loc('Editing Configuration for user [_1]', $UserObj->Name) &>
 
 <FORM ACTION="<%$RT::WebPath%>/Admin/Users/Modify.html" METHOD=POST>

html/Admin/Elements/QueueRightsForUser

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <UL>
 %while(my $ACE = $ACL->Next) {
 

html/Admin/Elements/QueueTabs

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <& /Admin/Elements/Tabs, subtabs => $subtabs, current_tab => 'Admin/Queues/' &>
 <hr>
 <%INIT>

html/Admin/Elements/SelectCustomFieldType

@@ -22,7 +22,6 @@
 %# 
 %# 
 %# END LICENSE BLOCK
-
 <SELECT NAME ="<%$Name%>">
 %for my $option (RT::CustomField->Types) {
 <OPTION VALUE="<%$option%>" <%$option eq $Default && "SELECTED"%>><% loc($option) %></OPTION>