1. 27 Aug, 2014 3 commits
  2. 25 Aug, 2014 2 commits
  3. 19 Aug, 2014 2 commits
  4. 18 Aug, 2014 6 commits
  5. 15 Aug, 2014 4 commits
  6. 13 Aug, 2014 7 commits
    • Kevin Falcone's avatar
      Allow the SuccessfulLogin callback to change where a user Redirects to · 6a923e70
      Kevin Falcone authored
      This allows an extension to overwrite a user's intended destination, or
      more usefully, detect when someone is logging in at the top level and
      redirect instead to a Dashboard (or in RTIR's case, to /RTIR/).
      6a923e70
    • Kevin Falcone's avatar
      Allow extra arguments to be passed to ShowHistory · ec0bb0d9
      Kevin Falcone authored
      RTIR wants to customize a number of paths during history display (see
      RTIR/Display.html and RTIR/Incident/Display.html).  In order to use
      delayed history loading, RTIR either needs to pass those as GET
      arguments (allowing user injection of paths that we use to build links,
      which is dangerous without sanitation) or otherwise get them to
      ShowHistory.
      
      With this, RTIR can just callback in the custom arguments (you can also
      clobber any of the other arguments to ShowHistory with it).
      ec0bb0d9
    • Kevin Falcone's avatar
      Ignore vim swap files when testing · 1dd472e6
      Kevin Falcone authored
      mason-syntax already ignored swp files, but would try to compile swo
      files.  t/web/helper-http-cache-headers.t made no attempt to ignore
      anything, so if you're hacking on a Helper this test will fail
      spectacularly.
      1dd472e6
    • Kevin Falcone's avatar
      Still delay loading when showing headers · 1ff7f30c
      Kevin Falcone authored
      In 75a405b5 we added the ForceShowHistory flag to Click to load history
      so that even if your JS was off, clicking on the link would load the
      page.
      
      This flag is also found in the Show Headers links added in 1a3327ce
      and I think added so that when you clicked on ShowHeaders with Click to
      load enable, you didn't *then* have to click on "Load history" just to
      see the headers.
      
      However, with delay, we already passed ShowHeaders to the helper, but
      clicking on Show Headers forced us to do the page load inline instead.
      This negates all of the perceived speed boost from delayed loading.
      Removing it from the delay case hasn't immediately broken things, and
      the delayed loading really doesn't play well with having JS off anyway.
      1ff7f30c
    • sunnavy's avatar
      make attachment truncate/drop and error txns more noticeable · 4aaa1324
      sunnavy authored
      color scheme is from cloos++
      4aaa1324
    • sunnavy's avatar
      test attachment dropping/truncation · 15452374
      sunnavy authored
      15452374
    • sunnavy's avatar
      record attachments' dropping/truncation as txns · 15dddd2e
      sunnavy authored
      15dddd2e
  7. 06 Aug, 2014 2 commits
    • Kevin Falcone's avatar
      Allow @Groupings to be passed in · b1ba2c3d
      Kevin Falcone authored
      The display template (ShowCustomFieldCustomGroupings) takes Groupings as
      an argument, for symmetry, also take it during editing.
      
      This allows code to better control which groups are shown
      on Create or other editing pages (in particular, RTIR and the multitude
      of complex editing/creating pages in that workflow).
      b1ba2c3d
    • Kevin Falcone's avatar
      RT::CustomField provides a wrapper to get the 'type', use it · 4abd0fa2
      Kevin Falcone authored
      Hardcoding ref here meant that if anything extends
      RT::CustomField->_GroupingClass, it'll fail to find the groupings and
      dump all your CFs into the Custom Fields group.  By calling back in to
      GroupingClass, you get the 'magic' type and can look it up in the
      groupings.
      
      NewItem provides an empty CustomField with ContextObject set which
      overriders of _GroupingClass can use for more context when
      LimitoToGrouping is called on an empty object (during object creation)
      
      RTIR uses this to provide an RTIR::Ticket grouping type so you can
      separate CF groupings on RTIR tickets from those on core tickets.
      Provided to allow better separation of groupings between RTIR CFs and
      CFs on other Queues, especially since RTIR uses common names such as
      'Customer' and 'IP' which would otherwise complicate using those CFs in
      groups in other Queues. Perhaps points towards wanting per-queue CF
      groupings.
      4abd0fa2
  8. 05 Aug, 2014 3 commits
  9. 04 Aug, 2014 2 commits
  10. 29 Jul, 2014 1 commit
  11. 25 Jul, 2014 2 commits
  12. 23 Jul, 2014 3 commits
  13. 22 Jul, 2014 2 commits
  14. 21 Jul, 2014 1 commit
    • Alex Vandiver's avatar
      Strip non-word characters from CF names for variable names · 546fc6c2
      Alex Vandiver authored
      The existing Simple templates did not address the issue of CF names with
      spaces in them.  This strips non-word characters to establish the
      variable name -- a trasformation which might cause duplication of CF
      names, but this does not notably worsen the situation, as they did not
      already posess any uniqueness guarantees.
      
      Note that this may still lead to unicode variable names, as \w is UTF-8
      aware, allowing for the variable "$TicketCFStraße".
      
      Fixes I#18446.
      546fc6c2