1. 20 Aug, 2012 9 commits
  2. 17 Aug, 2012 1 commit
  3. 16 Aug, 2012 5 commits
  4. 14 Aug, 2012 6 commits
  5. 13 Aug, 2012 1 commit
    • Kevin Falcone's avatar
      Whitelist Search/{Results.html,Simple.html} · 75a91cc3
      Kevin Falcone authored
      It's convenient to save or pass around links to search results rather
      than needing to save and share and then load the saved search.
      While there are potential issues here, it's much more user friendly
      to allow it.
      75a91cc3
  6. 09 Aug, 2012 1 commit
  7. 07 Aug, 2012 4 commits
  8. 03 Aug, 2012 2 commits
  9. 31 Jul, 2012 2 commits
    • Alex Vandiver's avatar
      Update shredder tests to heed the warning added in bc3212fe · d29975bf
      Alex Vandiver authored
      Due to the shredder tests not using RT::Test, no warning was actually
      output (and no test was failed) by code in the previous commit.
      Regardless, update the code to cope with the failure case as suggested.
      d29975bf
    • Alex Vandiver's avatar
      Warn if TransactionBatch would be triggered on shredded tickets · bc3212fe
      Alex Vandiver authored
      Since 1e280ff2, we switch the current user by creating a new RT::Ticket
      object and load the current ticket into it.  However, this also has a
      subtle behavior change -- previously, if a ticket had ending
      transactions and was removed from the underlying database, appropriate
      scrips would still be triggered for it, despite the ticket no longer
      existing.  Depending on the content of the scrips, this may have led to
      unexpected results.  In the new behavior, the ticket object passed to
      the scrips unexpectedly has no id.
      
      Before running _ApplyTransactionBatch, detect if the ticket record is no
      longer valid, and return, dropping the transactions; in doing so, warn
      of the confluence of events that led to this scenario, rare as it is.
      
      While this is technically a behavior change (from both before and after
      1e280ff2), it almost certainly only arises during testing, and previously
      generated subtly incorrect or inconsistent results.  The new behavior
      reports the failure, maintains consistency, and suggests a solution.
      bc3212fe
  10. 30 Jul, 2012 1 commit
  11. 18 Jul, 2012 7 commits
  12. 17 Jul, 2012 1 commit