- 12 Jun, 2014 4 commits
-
-
Jim Brandt authored
-
Jim Brandt authored
-
Jim Brandt authored
-
Alex Vandiver authored
-
- 06 Jun, 2014 1 commit
-
-
Alex Vandiver authored
It causes warnings when an accessor is called on an unloaded Scrip
-
- 05 Jun, 2014 14 commits
-
-
Alex Vandiver authored
- Updated Lithuanian translation - "Content is an invalid IP address" has been renamed to "Content is not a valid IP address" - "Input can not be parsed as an IP address" has been dropped.
-
Alex Vandiver authored
This reverts commit 40478732. The CF object may not be readable without context.
-
Kevin Falcone authored
-
Alex Vandiver authored
-
Alex Vandiver authored
Rather than reiterate the logic in the canonicalization functions, use the error condition they return to determine the validation error. This also opens the door for invalid date and datetime fields to abort ticket updates, by providing a validation error if they do not parse. For backwards compatibility, this does not enforce such.
-
Alex Vandiver authored
This merely serves to bulletproof the removal step; there is no need for the more expensive Load with Content.
-
Alex Vandiver authored
This ensures that IPs are padded to three digits per octet, and that dates are formatted in standard ISO time.
-
Alex Vandiver authored
-
Alex Vandiver authored
This allows CF creation to abort on invalid values, and HasEntry to give up and move on if passed a value that can never be found in the database.
-
Alex Vandiver authored
The IP address and range canonicalization in ObjectCustomFieldValue's Create is moved into the more general canonicalization functions. This also allows HasEntry can split IP ranges correctly to check their existance, and ensures that the standard form (padded to three digits per octet) is compared against the database.
-
Alex Vandiver authored
Previously, value canonicalization happened for dates and datetimes in RT::CustomField->AddValueForObject, and for IP addresses and ranges in RT::ObjectCustomFieldValue->Create. Standardize on the latter, as it is lower down and thus harder to skip accidentally. This requires creating the CustomField object as the current user, not as the system user, as Date and DateTime canonicalization cares about the time zone of the current user. This, in turn, requires switching to _Value('Type') instead of Type, as the constructed $cf object is not guaranteed to have the right context objects for it to be readable by the user.
-
Alex Vandiver authored
Refactor the two places that use can() into a common method.
-
Alex Vandiver authored
When comparing the canonicalized values, one must bear in mind that ->Content is not just the Content column in the database; instead, it falls back to the LongContent, in addition to doing explicit formatting for IP range custom fields. Compare the 'Content' key to what is actually in the 'Content' column, using $self->_Value(). This does not fix IP custom field updates, as the input Content has still not been split into Content and LargeContent as the database stores it.
-
Alex Vandiver authored
-
- 04 Jun, 2014 1 commit
-
-
Kevin Falcone authored
These tests are based on the RTIR initialdata file which identified the problem and fail on 4.2-trunk because of warnings generated during the initialdata load of t/api/initialdata.t I suspect we want to enhance our initialdata sample with any further Handle::InsertData hacking (or docs/initialdata.pod updates).
-
- 03 Jun, 2014 2 commits
-
-
Alex Vandiver authored
-
Alex Vandiver authored
Switching directly from Queue to ObjectId is not correct, as it fails to provide the ObjectType/LookupType hint.
-
- 30 May, 2014 5 commits
-
-
Alex Vandiver authored
-
Alex Vandiver authored
Conflicts: etc/RT_Config.pm.in etc/RT_SiteConfig.pm sbin/rt-test-dependencies.in share/html/Admin/Elements/EditRights share/html/Search/Bulk.html Bulk CF update moved to ProcessRecordBulkCustomFields in RT::Interface::Web in 4.2; move the change to there. It also requires protecting the new "update a single value" (added in bcb8f0f6) case to skip if HasEntry. Finally, drop the Repeated check, as the Repeated column was removed in d28b0a67.
-
Alex Vandiver authored
-
Kevin Falcone authored
As noted in ec5943dd, we have to do this so _ClassAccessible works properly in the importer. Now that we're serializing RT::ObjectScrip, we have to be sure to build attributes on it.
-
Alex Vandiver authored
This was left off in the confusion of the scripts-on-multiple-queues merge which ran in parallel to the serializer merge. Partially resolves #29949; note that it does not address the case of ObjectScrips when in a non-clone context.
-
- 29 May, 2014 2 commits
-
-
Alex Vandiver authored
-
Jim Brandt authored
-
- 28 May, 2014 6 commits
-
-
Kevin Falcone authored
-
Kevin Falcone authored
-
Kevin Falcone authored
-
Kevin Falcone authored
-
Alex Vandiver authored
-
Emmanuel Lacour authored
-
- 27 May, 2014 5 commits
-
-
Alex Vandiver authored
-
Alex Vandiver authored
-
Kevin Falcone authored
f0137c97 deleted ShowTitleBarCommands but commits which were merged later (0d8eacf3 and 775f4bd1) used them for newly refactored code, causing Reply/Comment/Forward to pop up all over the Approvals display, and generating links that either loop back to the approvals page or otherwise don't work.
-
Kevin Falcone authored
The previous commit removed an outer if block and pushed it into the boolean check of the elsif, leaving it weirdly indented. This left shifts everything as a separate commit to make reading the previous code change clearer.
-
Kevin Falcone authored
The 4.2 equivalent ShowActions should be compatible for the places that want to suppress Reply/Comment/Forward. This makes the code change, leaves whitespace terrible.
-