- 15 Aug, 2014 2 commits
-
-
Alex Vandiver authored
-
Wallace Reis authored
-
- 06 Aug, 2014 2 commits
-
-
Kevin Falcone authored
The display template (ShowCustomFieldCustomGroupings) takes Groupings as an argument, for symmetry, also take it during editing. This allows code to better control which groups are shown on Create or other editing pages (in particular, RTIR and the multitude of complex editing/creating pages in that workflow).
-
Kevin Falcone authored
Hardcoding ref here meant that if anything extends RT::CustomField->_GroupingClass, it'll fail to find the groupings and dump all your CFs into the Custom Fields group. By calling back in to GroupingClass, you get the 'magic' type and can look it up in the groupings. NewItem provides an empty CustomField with ContextObject set which overriders of _GroupingClass can use for more context when LimitoToGrouping is called on an empty object (during object creation) RTIR uses this to provide an RTIR::Ticket grouping type so you can separate CF groupings on RTIR tickets from those on core tickets. Provided to allow better separation of groupings between RTIR CFs and CFs on other Queues, especially since RTIR uses common names such as 'Customer' and 'IP' which would otherwise complicate using those CFs in groups in other Queues. Perhaps points towards wanting per-queue CF groupings.
-
- 05 Aug, 2014 3 commits
-
-
Alex Vandiver authored
Launchpad parsing objects to msgids which are not followed by empty msgstr's in .pot files.
-
Alex Vandiver authored
-
Alex Vandiver authored
-
- 04 Aug, 2014 2 commits
-
-
Alex Vandiver authored
-
Alex Vandiver authored
-
- 29 Jul, 2014 1 commit
-
-
sunnavy authored
-
- 25 Jul, 2014 1 commit
-
-
Ruslan Zakirov authored
Old "message recorded" is confusing as it doesn't differentiate between correspond and comment.
-
- 23 Jul, 2014 3 commits
-
-
Wallace Reis authored
-
Wallace Reis authored
-
Wallace Reis authored
-
- 22 Jul, 2014 2 commits
-
-
Alex Vandiver authored
-
Jeff Blaine authored
-
- 21 Jul, 2014 1 commit
-
-
Wallace Reis authored
-
- 18 Jul, 2014 1 commit
-
-
Wallace Reis authored
-
- 17 Jul, 2014 7 commits
-
-
Alex Vandiver authored
-
Wallace Reis authored
-
Wallace Reis authored
-
Alex Vandiver authored
Passing $@ to loc() causes its value to not be examined until later, when it is substituted into the string. Between the ->require error and then, the loc() machinery attempts to run for the first time, which _also_ requires files, thus overwriting the original error in $@. Store the error found in $@ away into a different variable, to ensure that it is not lost before it is used. Passing "$@" instead of $@ would similarly suffice, but the clarity of the extra variable is preferrable. Fixes I#22991.
-
Alex Vandiver authored
-
Alex Vandiver authored
-
Alex Vandiver authored
As "GECOS" is what RT calls the field in a number of places, provide that name in the error message.
-
- 16 Jul, 2014 5 commits
-
-
Alex Vandiver authored
-
Alex Vandiver authored
Per I#30232. This blacklist will be removed in a future release, likely replaced by a dependency bump of DBIx::SearchBuilder for PostgreSQL deployments.
-
Wallace Reis authored
-
Alex Vandiver authored
Fixes I#21309.
-
Wallace Reis authored
-
- 10 Jul, 2014 2 commits
-
-
Alex Vandiver authored
-
Wallace Reis authored
-
- 09 Jul, 2014 4 commits
-
-
Alex Vandiver authored
The $LogoImageHeight and $LogoImageWidth configurations were only output on the <img> tag if the stock BPS logo was in use. Additionally, however, those values were ignored by the browser, because every RT style sets: div#logo a img { height: 100% !important; width: auto !important; } ...which overrides explicit height="..." and width=".." attributes. Remove the configuration options which thus do not actually control anything. Fixes: I#26827
-
Wallace Reis authored
-
Kadar Attila authored
-
Kadar Attila authored
Pull request: #102
-
- 08 Jul, 2014 1 commit
-
-
Kevin Falcone authored
-
- 07 Jul, 2014 3 commits
-
-
Alex Vandiver authored
-
Alex Vandiver authored
While 2a2198bc fixed the display of the HTML → text conversion for text/plain embedded in an HTML template, it failed to address the ckeditor, which suffered from a similar problem. Notably, the ckeditor formatted <pre><div>...</div></pre> as <pre></pre><div>...</div>; while the <div> maintained its style, all whitespace had been compressed from its original value, leaving the style pointless. This table shows the previous states of this code, and its failures: MARKUP | MUA | HTML->TEXT | CKEDITOR ------------------+--------------+---------------+--------------- <pre> | doesn't wrap | GOOD | GOOD 75cdfc91 | long lines | | ------------------+--------------+---------------+--------------- <div style> | GOOD | whitespace | whitespace 6b117af0 | | not preserved | not preserved ------------------+--------------+---------------+--------------- <pre><div style> | GOOD | GOOD | whitespace 2a2198bc | | | not preserved ------------------+--------------+---------------+--------------- <pre style> | GOOD | GOOD | GOOD (this commit) | | | Swap to using <pre style="...">...</pre>, which MUAs and ckeditor render acceptably, and the stock HTML → text conversion preserves whitespace in. Fixes: I#30198
-
Wallace Reis authored
-