1. 15 Aug, 2014 2 commits
  2. 06 Aug, 2014 2 commits
    • Kevin Falcone's avatar
      Allow @Groupings to be passed in · b1ba2c3d
      Kevin Falcone authored
      The display template (ShowCustomFieldCustomGroupings) takes Groupings as
      an argument, for symmetry, also take it during editing.
      
      This allows code to better control which groups are shown
      on Create or other editing pages (in particular, RTIR and the multitude
      of complex editing/creating pages in that workflow).
      b1ba2c3d
    • Kevin Falcone's avatar
      RT::CustomField provides a wrapper to get the 'type', use it · 4abd0fa2
      Kevin Falcone authored
      Hardcoding ref here meant that if anything extends
      RT::CustomField->_GroupingClass, it'll fail to find the groupings and
      dump all your CFs into the Custom Fields group.  By calling back in to
      GroupingClass, you get the 'magic' type and can look it up in the
      groupings.
      
      NewItem provides an empty CustomField with ContextObject set which
      overriders of _GroupingClass can use for more context when
      LimitoToGrouping is called on an empty object (during object creation)
      
      RTIR uses this to provide an RTIR::Ticket grouping type so you can
      separate CF groupings on RTIR tickets from those on core tickets.
      Provided to allow better separation of groupings between RTIR CFs and
      CFs on other Queues, especially since RTIR uses common names such as
      'Customer' and 'IP' which would otherwise complicate using those CFs in
      groups in other Queues. Perhaps points towards wanting per-queue CF
      groupings.
      4abd0fa2
  3. 05 Aug, 2014 3 commits
  4. 04 Aug, 2014 2 commits
  5. 29 Jul, 2014 1 commit
  6. 25 Jul, 2014 1 commit
  7. 23 Jul, 2014 3 commits
  8. 22 Jul, 2014 2 commits
  9. 21 Jul, 2014 1 commit
  10. 18 Jul, 2014 1 commit
  11. 17 Jul, 2014 7 commits
  12. 16 Jul, 2014 5 commits
  13. 10 Jul, 2014 2 commits
  14. 09 Jul, 2014 4 commits
  15. 08 Jul, 2014 1 commit
  16. 07 Jul, 2014 3 commits
    • Alex Vandiver's avatar
      Update PO files from Launchpad · d6c77eb3
      Alex Vandiver authored
      d6c77eb3
    • Alex Vandiver's avatar
      Fix line wrapping of text → HTML in ckeditor · 59c16b89
      Alex Vandiver authored
      While 2a2198bc fixed the display of the HTML → text conversion for
      text/plain embedded in an HTML template, it failed to address the
      ckeditor, which suffered from a similar problem.
      
      Notably, the ckeditor formatted <pre><div>...</div></pre> as
      <pre></pre><div>...</div>; while the <div> maintained its style, all
      whitespace had been compressed from its original value, leaving the
      style pointless.
      
      This table shows the previous states of this code, and its failures:
      
         MARKUP           |     MUA      |  HTML->TEXT   |   CKEDITOR
        ------------------+--------------+---------------+---------------
         <pre>            | doesn't wrap | GOOD          | GOOD
           75cdfc91       | long lines   |               |
        ------------------+--------------+---------------+---------------
         <div style>      | GOOD         | whitespace    | whitespace
           6b117af0       |              | not preserved | not preserved
        ------------------+--------------+---------------+---------------
         <pre><div style> | GOOD         | GOOD          | whitespace
           2a2198bc       |              |               | not preserved
        ------------------+--------------+---------------+---------------
         <pre style>      | GOOD         | GOOD          | GOOD
           (this commit)  |              |               |
      
      Swap to using <pre style="...">...</pre>, which MUAs and ckeditor render
      acceptably, and the stock HTML → text conversion preserves whitespace
      in.
      
      Fixes: I#30198
      59c16b89
    • Wallace Reis's avatar
      a6aee8d3