GitLab

Conflicts:
	t/015-make-clicky.t

Provide a method which gives the standard RTIR Queues so you don't have
to hardcode lists in other code.  Use it to fix the hardcoded list in
the QueueSummary SQLFilter code.

It was never updated when the RTIR specific QueueSummary was removed
in 7044f2f1.  Back in 3.8, this hid all RTIR Queues from the RT homepage
and then there was a custom RTIR portlet.  RTIR now just uses standard
Quicksearch which dispatches off to QueueSummaryByLifecycle (or ByStatus
if you prefer).  This means we need to filter only Constituency Queues.

Instead of filtering after we get the Queue list, filter in SQL using
the new callbacks in 4.0. This should be more efficient for sites with a
bunch of Queues or Constituencies.

Since a lot of RTIR code checks Queue::HasRight (particularly on CF right
checks) this was a ton of DB fetches to go get all the Constituency
Queues.  Just having the Constituency CF caused the queries, even if
there were no Queues to find.

This was especially apparent in the REST interface where merely listing
open Incident Reports caused thousands of SELECT main.* from Queues
where Name like 'Incidents - %';

besides, current backend code doesn't handle rich text either.

Without the Queue, it searches too widely and throws a lot of warnings
and errors.

This requires 43f534acd from 4.0-trunk which will be in 4.0.20

Accidentally made make snapshot not work anymore

There are several variable interpolation strings we should fix, but this
is a quick first start before it ends up on 3.0-trunk and then on
launchpad.

This clones RT's incant (minus the configuration for the hardcoded 5).
I admit that this is largely so my shell aliases that work on RT also
work on RTIR so that I can run the test suite quickly.

Otherwise, example.com or email addresses anywhere in the history of a
ticket in the General queue ends up with links off to
/RTIR/Tools/Lookup.html.  Normal users have no idea why those links are
there and they're frankly ugly and cluttering outside the RTIR workflow.

A ticket in the Incidents queue is of type Incident, so there is that
small change in the incident if.  TicketType can also return undef so we have to
guard.

We use the ticket type to skip doing other replacements.

The portlets on the RTIR homepage now have a little more flexibility
without requiring mason overlays.

Allows us to explode nicely when people try to install on RT 4.2.x

Needed updated license_tag from 4.0/copyright-2014

All this does is force mysql to sort (possibly filesort) and we really
don't care about the order when we're going to use it to feed an update
or delete.

When MySQL optimizes our UPDATE where id in (SELECT) it doesn't know
that the tables are linked, so it ends up walking and examining lots and
lots of rows.  Including the ObjectType column means that mysql can
easily examine 1 row using our existing ObjectCustomFieldValues2 index
and update immediately.

There is no longer a need to add upgrade specific indexes for OCFVs (the
transaction indexes still improve performance).

RT::Ticket->SubjectTag was implemented about 2 weeks after RTIR was
udpated to use SubjectTags.  Unfortunately, RTIR wasn't fixed to use it
until now.