1. 18 Jul, 2014 3 commits
  2. 17 Jul, 2014 3 commits
    • Kevin Falcone's avatar
    • Kevin Falcone's avatar
      Make "Jump to unread" work · 747a6150
      Kevin Falcone authored
      Without this and 4.0/updatestatus-displaypath, Jump to unread will link
      to /Ticket/Display.html?id=7#txn-id=foo but during the redirect to
      /RTIR/Display.html the anchor is lost and the page never moves.  You can
      click the link all you want.
      Mark as read and jump works because it passes the Anchor in an argument
      which is respected in MaybeRedirectForResults.
    • Kevin Falcone's avatar
      This code will happily load a Disabled Queue and use it · bfec1f4d
      Kevin Falcone authored
      If you've tried to go away from Constituency queues, you may have
      disabled Queues.  If that Queue has an empty CorrespondAddress, you'll
      get warnings before RTIR falls back to the Global settings.  If it has a
      CorrespondAddress, RTIR will try to use that instead.
  3. 12 Jun, 2014 2 commits
  4. 11 Jun, 2014 2 commits
  5. 06 Jun, 2014 1 commit
    • Kevin Falcone's avatar
      Remove misleading note about which IRs are counted · 3131f5a8
      Kevin Falcone authored
      When this line was introduced in RTIR 1 in 5892d273 the message only
      showed up in the tabbed output, but the code did correctly handle IRs
      without Incidents (although it meant that it wouldn't even consider the
      Constituency field on the IR itself which is.. odd).
      When this code was refactored in 0553622d it took some very simple logic
      and replaced it with clever and wrong code that failed to consider the
      fact that a subroutine was returning undef as a special "No linked
      Incident" case.
      next unless ($value eq $Constituency || !defined $value);
      became the "failing to consider undef"
      delete $res->{$id} if !$value || $value ne $condition;
      even the current code which uses a ternary operator gets undef wrong and
      can only count unlinked IRs with the yet-to-be-merged branch that allows
      Constituency to be optional.
      While it's straightforward to return the original behavior, it's been
      broken since 2.4.0 was released, so we won't fix it in
      3.0-trunk.  End goal is that RTIR should get enough of RT's reporting to
      not need this thing anymore.
  6. 13 May, 2014 2 commits
  7. 06 May, 2014 3 commits
  8. 01 May, 2014 4 commits
  9. 24 Apr, 2014 2 commits
  10. 10 Apr, 2014 1 commit
  11. 09 Apr, 2014 3 commits
  12. 07 Apr, 2014 1 commit
    • Kevin Falcone's avatar
      Remove more _RTIR prefix code · af64dc21
      Kevin Falcone authored
      This use of _RTIR was missed during the renaming before 2.6.
      Without 1b6ac90c and this commit, this script really only about 1/3
      worked for the whole 2.6 release series. Constituency duty teams had
      many permissions on tickets, but no access to the relevant custom fields
      unless more work was done to hand those rights out manually.
      This takes any CF applied to an IR queue and grants the constituency
      duty team rights on those CFs. This means that new custom CFs added by
      an admin will be picked up (not just core RTIR fields) but this is more
      likely to be what admins want and is simpler than coding a list of CFs
      into the script that will bitrot.
  13. 02 Apr, 2014 3 commits
  14. 01 Apr, 2014 1 commit
    • Kevin Falcone's avatar
      This callback no longer functions in 4.0 · 427256c4
      Kevin Falcone authored
      It was never updated when the RTIR specific QueueSummary was removed
      in 7044f2f1.  Back in 3.8, this hid all RTIR Queues from the RT homepage
      and then there was a custom RTIR portlet.  RTIR now just uses standard
      Quicksearch which dispatches off to QueueSummaryByLifecycle (or ByStatus
      if you prefer).  This means we need to filter only Constituency Queues.
      Instead of filtering after we get the Queue list, filter in SQL using
      the new callbacks in 4.0. This should be more efficient for sites with a
      bunch of Queues or Constituencies.
  15. 31 Mar, 2014 2 commits
  16. 25 Mar, 2014 3 commits
  17. 24 Mar, 2014 1 commit
  18. 06 Mar, 2014 1 commit
  19. 28 Feb, 2014 1 commit
    • Kevin Falcone's avatar
      Every time Queue::HasRight was checked, we loaded Queues from the DB · 1f5fb2a9
      Kevin Falcone authored
      Since a lot of RTIR code checks Queue::HasRight (particularly on CF right
      checks) this was a ton of DB fetches to go get all the Constituency
      Queues.  Just having the Constituency CF caused the queries, even if
      there were no Queues to find.
      This was especially apparent in the REST interface where merely listing
      open Incident Reports caused thousands of SELECT main.* from Queues
      where Name like 'Incidents - %';
  20. 24 Feb, 2014 1 commit