GitLab

unfortunately, this newer version of Module::Install::RTx wants to
overwrite README, so until we sort that out, we'll need to be careful
when running perl Makefile.PL as an author.

Without this and 4.0/updatestatus-displaypath, Jump to unread will link
to /Ticket/Display.html?id=7#txn-id=foo but during the redirect to
/RTIR/Display.html the anchor is lost and the page never moves.  You can
click the link all you want.

Mark as read and jump works because it passes the Anchor in an argument
which is respected in MaybeRedirectForResults.

If you've tried to go away from Constituency queues, you may have
disabled Queues.  If that Queue has an empty CorrespondAddress, you'll
get warnings before RTIR falls back to the Global settings.  If it has a
CorrespondAddress, RTIR will try to use that instead.

Add support for displaying a message on ticket display when
there are unread messages on a ticket. This is a standard
feature in core RT.

Adding this feature gives users a way to clear the New messages
setting shown on the incidents listing on the RTIR homepage
which was added in 726463f3.

Resolves issues 17450 and 30080

With this commit, the Constituency CF is now loaded as the
current user rather than the SystemUser because only users
with access to the Constituency CF should see it in the
reporting menu. However, it is a behavior change that may be
noticed by some users with more customized rights configurations.

Resolves Issues: 30040

When this line was introduced in RTIR 1 in 5892d273 the message only
showed up in the tabbed output, but the code did correctly handle IRs
without Incidents (although it meant that it wouldn't even consider the
Constituency field on the IR itself which is.. odd).

When this code was refactored in 0553622d it took some very simple logic
and replaced it with clever and wrong code that failed to consider the
fact that a subroutine was returning undef as a special "No linked
Incident" case.

next unless ($value eq $Constituency || !defined $value);
became the "failing to consider undef"
delete $res->{$id} if !$value || $value ne $condition;
even the current code which uses a ternary operator gets undef wrong and
can only count unlinked IRs with the yet-to-be-merged branch that allows
Constituency to be optional.

While it's straightforward to return the original behavior, it's been
broken since 2.4.0 was released, so we won't fix it in
3.0-trunk.  End goal is that RTIR should get enough of RT's reporting to
not need this thing anymore.

Manually futzed versions back to 3.0.HEAD

On a new enough version of RT, this subroutine will be executed on any
MakeClicky call.  This allows us to cache for 6 hours the results of
generating links to Lookup.html (in particular, on tickets with lots of
IPs in history, this is a huge win).  Even on tickets needing minimal
processing, it helps speed up display.

One interesting quirk of this code is that MakeClicky is run on Whois
lookups and traceroute.  Traceroute provides no useful details (not even
the ticket) so it's kind of a lost cause.  Whois on the other hand
provides lookup_params, and when we get that we should punt on the
caching so we don't provide links to the wrong ticket object.

3db519e8 refactored code into a MapStatus method, but it removed the
check to see if Status had a value.  Since most uses of this page
explicitly set Status = '' (since Status isn't changing) it causes a
warning in the logs any time you reply to an Incident.

MapStatus does 'return unless $Status', so you're guaranteed to get the
odd number of elements in a hash warning on reply.

Conflicts:
	t/015-make-clicky.t

When the language for this changed in b29757e this stopped working.
Rather than regexing the error message, just check if the right exists.

This use of _RTIR was missed during the renaming before 2.6.
Without 1b6ac90c and this commit, this script really only about 1/3
worked for the whole 2.6 release series. Constituency duty teams had
many permissions on tickets, but no access to the relevant custom fields
unless more work was done to hand those rights out manually.

This takes any CF applied to an IR queue and grants the constituency
duty team rights on those CFs. This means that new custom CFs added by
an admin will be picked up (not just core RTIR fields) but this is more
likely to be what admins want and is simpler than coding a list of CFs
into the script that will bitrot.

Provide a method which gives the standard RTIR Queues so you don't have
to hardcode lists in other code.  Use it to fix the hardcoded list in
the QueueSummary SQLFilter code.

It was never updated when the RTIR specific QueueSummary was removed
in 7044f2f1.  Back in 3.8, this hid all RTIR Queues from the RT homepage
and then there was a custom RTIR portlet.  RTIR now just uses standard
Quicksearch which dispatches off to QueueSummaryByLifecycle (or ByStatus
if you prefer).  This means we need to filter only Constituency Queues.

Instead of filtering after we get the Queue list, filter in SQL using
the new callbacks in 4.0. This should be more efficient for sites with a
bunch of Queues or Constituencies.

Since a lot of RTIR code checks Queue::HasRight (particularly on CF right
checks) this was a ton of DB fetches to go get all the Constituency
Queues.  Just having the Constituency CF caused the queries, even if
there were no Queues to find.

This was especially apparent in the REST interface where merely listing
open Incident Reports caused thousands of SELECT main.* from Queues
where Name like 'Incidents - %';

besides, current backend code doesn't handle rich text either.