1. 09 Apr, 2014 1 commit
    • Kevin Falcone's avatar
      Fix "already granted" logic · 78edc3a5
      Kevin Falcone authored
      When the language for this changed in b29757e this stopped working.
      Rather than regexing the error message, just check if the right exists.
  2. 07 Apr, 2014 1 commit
    • Kevin Falcone's avatar
      Remove more _RTIR prefix code · af64dc21
      Kevin Falcone authored
      This use of _RTIR was missed during the renaming before 2.6.
      Without 1b6ac90c and this commit, this script really only about 1/3
      worked for the whole 2.6 release series. Constituency duty teams had
      many permissions on tickets, but no access to the relevant custom fields
      unless more work was done to hand those rights out manually.
      This takes any CF applied to an IR queue and grants the constituency
      duty team rights on those CFs. This means that new custom CFs added by
      an admin will be picked up (not just core RTIR fields) but this is more
      likely to be what admins want and is simpler than coding a list of CFs
      into the script that will bitrot.
  3. 02 Apr, 2014 3 commits
  4. 01 Apr, 2014 1 commit
    • Kevin Falcone's avatar
      This callback no longer functions in 4.0 · 427256c4
      Kevin Falcone authored
      It was never updated when the RTIR specific QueueSummary was removed
      in 7044f2f1.  Back in 3.8, this hid all RTIR Queues from the RT homepage
      and then there was a custom RTIR portlet.  RTIR now just uses standard
      Quicksearch which dispatches off to QueueSummaryByLifecycle (or ByStatus
      if you prefer).  This means we need to filter only Constituency Queues.
      Instead of filtering after we get the Queue list, filter in SQL using
      the new callbacks in 4.0. This should be more efficient for sites with a
      bunch of Queues or Constituencies.
  5. 31 Mar, 2014 2 commits
  6. 25 Mar, 2014 3 commits
  7. 24 Mar, 2014 1 commit
  8. 06 Mar, 2014 1 commit
  9. 28 Feb, 2014 1 commit
    • Kevin Falcone's avatar
      Every time Queue::HasRight was checked, we loaded Queues from the DB · 1f5fb2a9
      Kevin Falcone authored
      Since a lot of RTIR code checks Queue::HasRight (particularly on CF right
      checks) this was a ton of DB fetches to go get all the Constituency
      Queues.  Just having the Constituency CF caused the queries, even if
      there were no Queues to find.
      This was especially apparent in the REST interface where merely listing
      open Incident Reports caused thousands of SELECT main.* from Queues
      where Name like 'Incidents - %';
  10. 24 Feb, 2014 1 commit
  11. 21 Feb, 2014 1 commit
  12. 06 Feb, 2014 1 commit
  13. 05 Feb, 2014 3 commits
  14. 29 Jan, 2014 3 commits
  15. 28 Jan, 2014 3 commits
    • Kevin Falcone's avatar
      Provide a parallel-test target · 9b49c1b6
      Kevin Falcone authored
      This clones RT's incant (minus the configuration for the hardcoded 5).
      I admit that this is largely so my shell aliases that work on RT also
      work on RTIR so that I can run the test suite quickly.
    • Kevin Falcone's avatar
      Start returning early if we're acting on a non-RTIR ticket. · ca41f89a
      Kevin Falcone authored
      Otherwise, example.com or email addresses anywhere in the history of a
      ticket in the General queue ends up with links off to
      /RTIR/Tools/Lookup.html.  Normal users have no idea why those links are
      there and they're frankly ugly and cluttering outside the RTIR workflow.
    • Kevin Falcone's avatar
      Refactor to store the ticket type · ec305bba
      Kevin Falcone authored
      A ticket in the Incidents queue is of type Incident, so there is that
      small change in the incident if.  TicketType can also return undef so we have to
      We use the ticket type to skip doing other replacements.
  16. 17 Jan, 2014 2 commits
  17. 10 Jan, 2014 3 commits
  18. 08 Jan, 2014 1 commit
  19. 06 Jan, 2014 1 commit
  20. 22 Nov, 2013 4 commits
    • Kevin Falcone's avatar
      There's no need to sort the subselect · 63045f16
      Kevin Falcone authored
      All this does is force mysql to sort (possibly filesort) and we really
      don't care about the order when we're going to use it to feed an update
      or delete.
    • Kevin Falcone's avatar
      Improve our Dependent Subclause · 3d212688
      Kevin Falcone authored
      When MySQL optimizes our UPDATE where id in (SELECT) it doesn't know
      that the tables are linked, so it ends up walking and examining lots and
      lots of rows.  Including the ObjectType column means that mysql can
      easily examine 1 row using our existing ObjectCustomFieldValues2 index
      and update immediately.
      There is no longer a need to add upgrade specific indexes for OCFVs (the
      transaction indexes still improve performance).
    • Kevin Falcone's avatar
      typo · f6dcd4cb
      Kevin Falcone authored
    • Kevin Falcone's avatar
      Use $Ticket->SubjectTag rather than reimplementing it · 326ba231
      Kevin Falcone authored
      RT::Ticket->SubjectTag was implemented about 2 weeks after RTIR was
      udpated to use SubjectTags.  Unfortunately, RTIR wasn't fixed to use it
      until now.
  21. 22 Aug, 2013 3 commits