From 24c755d93456f922244ee71b8682fa0adc55eec5 Mon Sep 17 00:00:00 2001
From: Alex Barth <alex_b@53995.no-reply.drupal.org>
Date: Sun, 11 Jul 2010 01:10:52 +0000
Subject: [PATCH] #850638: Introduce FeedsSource::preview().
---
CHANGELOG.txt | 1 +
feeds.module | 5 +----
includes/FeedsSource.inc | 15 +++++++++++++++
3 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/CHANGELOG.txt b/CHANGELOG.txt
index bd7343a9..4df33105 100644
--- a/CHANGELOG.txt
+++ b/CHANGELOG.txt
@@ -3,6 +3,7 @@
Feeds 6.x 1.X XXXX
------------------
+- #850638 alex_b: Introduce FeedsSource::preview().
- #850298 alex_b: ParserCSV: Support batching (only affects library, full parser
level batch support to be added later with #744660).
- Minor cleanup of admin UI language and CSS.
diff --git a/feeds.module b/feeds.module
index 67f364a4..ac62b504 100644
--- a/feeds.module
+++ b/feeds.module
@@ -271,10 +271,7 @@ function feeds_nodeapi(&$node, $op, $form) {
if (trim($node->title) == '') {
try {
$source->addConfig($node_feeds);
- // @todo Too many indirections. Clean up.
- $batch = $source->importer->fetcher->fetch($source);
- $source->importer->parser->parse($batch, $source);
- if (!$last_title = $batch->getTitle()) {
+ if (!$last_title = $source->preview()->getTitle()) {
throw new Exception();
}
}
diff --git a/includes/FeedsSource.inc b/includes/FeedsSource.inc
index 8f7b3dec..81ad94f1 100644
--- a/includes/FeedsSource.inc
+++ b/includes/FeedsSource.inc
@@ -110,6 +110,21 @@ class FeedsSource extends FeedsConfigurable {
$this->load();
}
+ /**
+ * Preview = fetch and parse a feed.
+ *
+ * @return
+ * FeedsImportBatch object, fetched and parsed.
+ *
+ * @throws
+ * Throws Exception if an error occurs when fetching or parsing.
+ */
+ public function preview() {
+ $batch = $this->importer->fetcher->fetch($this);
+ $this->importer->parser->parse($batch, $this);
+ return $batch;
+ }
+
/**
* Import a feed: execute, fetching, parsing and processing stage.
*
--
GitLab