From 510a49a08af6d32176d49838509cb03cccea0924 Mon Sep 17 00:00:00 2001
From: Liam Morland <lkmorlan@uwaterloo.ca>
Date: Wed, 12 Jun 2019 17:01:26 -0400
Subject: [PATCH] Coding standards
---
tests/FillPdfMergeTestCase.test | 16 +++++++++++-----
tests/FillPdfTestHelper.test | 2 +-
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/tests/FillPdfMergeTestCase.test b/tests/FillPdfMergeTestCase.test
index 356f847..f630d07 100644
--- a/tests/FillPdfMergeTestCase.test
+++ b/tests/FillPdfMergeTestCase.test
@@ -12,7 +12,7 @@ class FillPdfMergeTestCase extends ImageFieldTestCase {
protected $nonPrivilegedUser;
/**
- *
+ * {@inheritdoc}
*/
public static function getInfo() {
// Note: getInfo() strings are not translated with t().
@@ -24,7 +24,7 @@ class FillPdfMergeTestCase extends ImageFieldTestCase {
}
/**
- *
+ * {@inheritdoc}
*/
public function setUp() {
parent::setUp();
@@ -56,6 +56,7 @@ class FillPdfMergeTestCase extends ImageFieldTestCase {
}
/**
+ * Test PDF merging.
*
* @throws \FieldException
*/
@@ -292,7 +293,12 @@ class FillPdfMergeTestCase extends ImageFieldTestCase {
}
}
$expected_filename = 'Token_Test_term_title.pdf';
- $this->assertEqual($expected_filename, $filename, t('Filename of generated file (@actual) matches specified entity token pattern (@expected). Current page URL: @url', array('@actual' => $filename, '@expected' => $expected_filename, '@url' => $where_are_we)));
+ $args = array(
+ '@actual' => $filename,
+ '@expected' => $expected_filename,
+ '@url' => $where_are_we,
+ );
+ $this->assertEqual($expected_filename, $filename, t('Filename of generated file (@actual) matches specified entity token pattern (@expected). Current page URL: @url', $args));
// Test that node access via entity access works.
// Make a basic page.
@@ -517,7 +523,7 @@ class FillPdfMergeTestCase extends ImageFieldTestCase {
}
/**
- *
+ * Tests PDF merging using a local service.
*/
public function testLocalServicePdfMerging() {
$this->configureLocalServiceBackend();
@@ -553,7 +559,7 @@ class FillPdfMergeTestCase extends ImageFieldTestCase {
}
/**
- *
+ * Tests PDF merging.
*/
protected function backendTest() {
$this->uploadTestPdf();
diff --git a/tests/FillPdfTestHelper.test b/tests/FillPdfTestHelper.test
index 780724d..2888dd7 100644
--- a/tests/FillPdfTestHelper.test
+++ b/tests/FillPdfTestHelper.test
@@ -1,7 +1,7 @@
<?php
/**
- *
+ * Helper functions for FillPDF testing.
*/
trait FillPdfTestHelper {
--
GitLab