diff --git a/composer.json b/composer.json index 605f1fef67050701f7c751a750084f0a53a8e033..00074518d6e8c9be2bf978716855acd2c36b2cc5 100644 --- a/composer.json +++ b/composer.json @@ -11,6 +11,7 @@ ], "minimum-stability": "dev", "require": { + "php": "^7.2", "drupal/core": "^8.8 || ^9", "drupal/token": "^1.0" }, diff --git a/fillpdf.info.yml b/fillpdf.info.yml index bda41df5d04cee344bab98a212d5b78815ccd763..e547fe70a7f4cfdb73e596a8b70f940d439b61d8 100644 --- a/fillpdf.info.yml +++ b/fillpdf.info.yml @@ -13,4 +13,5 @@ dependencies: - drupal:options test_dependencies: - webform:webform - - xmlrpc:xmlrpc + # xmlrpc does not have a Drupal 9 release yet. + # - xmlrpc:xmlrpc diff --git a/src/Form/FillPdfFormForm.php b/src/Form/FillPdfFormForm.php index c03efdc45f0819a165cc93d74bb77a3b9eed61cc..49e0f2ce67d85486116e05efbb8e21e8e67fa69e 100644 --- a/src/Form/FillPdfFormForm.php +++ b/src/Form/FillPdfFormForm.php @@ -2,11 +2,14 @@ namespace Drupal\fillpdf\Form; +use Drupal\Component\Datetime\TimeInterface; use Drupal\Core\Entity\ContentEntityForm; use Drupal\Core\Entity\EntityRepositoryInterface; +use Drupal\Core\Entity\EntityTypeBundleInfoInterface; use Drupal\Core\Entity\EntityTypeManager; use Drupal\Core\File\FileSystemInterface; use Drupal\Core\Form\FormStateInterface; +use Drupal\Core\Link; use Drupal\Core\Url; use Drupal\file\Entity\File; use Drupal\fillpdf\Component\Utility\FillPdf; @@ -16,7 +19,6 @@ use Drupal\fillpdf\InputHelperInterface; use Drupal\fillpdf\SerializerInterface; use Drupal\fillpdf\TokenResolverInterface; use Symfony\Component\DependencyInjection\ContainerInterface; -use Drupal\Core\Link; /** * Form controller for the FillPDFForm edit form. @@ -71,24 +73,7 @@ class FillPdfFormForm extends ContentEntityForm { protected $tokenResolver; /** - * Constructs a FillPdfFormForm object. - * - * @param \Drupal\Core\Entity\EntityRepositoryInterface $entity_repository - * The entity repository service. - * @param \Drupal\fillpdf\FillPdfAdminFormHelperInterface $admin_form_helper - * FillPdf admin form helper. - * @param \Drupal\fillpdf\FillPdfLinkManipulatorInterface $link_manipulator - * FillPdf link manipulator. - * @param \Drupal\fillpdf\InputHelperInterface $input_helper - * FillPdf link manipulator. - * @param \Drupal\fillpdf\SerializerInterface $fillpdf_serializer - * FillPdf serializer. - * @param \Drupal\Core\File\FileSystemInterface $file_system - * Helpers to operate on files and stream wrappers. - * @param \Drupal\Core\Entity\EntityTypeManager $entity_type_manager - * The entity repository service. - * @param \Drupal\fillpdf\TokenResolverInterface $token_resolver - * The FillPDF token resolver. + * {@inheritdoc} */ public function __construct( EntityRepositoryInterface $entity_repository, @@ -98,10 +83,14 @@ class FillPdfFormForm extends ContentEntityForm { SerializerInterface $fillpdf_serializer, FileSystemInterface $file_system, EntityTypeManager $entity_type_manager, - TokenResolverInterface $token_resolver + TokenResolverInterface $token_resolver, + EntityTypeBundleInfoInterface $entity_type_bundle_info, + TimeInterface $time ) { parent::__construct( - $entity_repository + $entity_repository, + $entity_type_bundle_info, + $time ); $this->adminFormHelper = $admin_form_helper; $this->linkManipulator = $link_manipulator; @@ -124,7 +113,9 @@ class FillPdfFormForm extends ContentEntityForm { $container->get('fillpdf.serializer'), $container->get('file_system'), $container->get('entity_type.manager'), - $container->get('fillpdf.token_resolver') + $container->get('fillpdf.token_resolver'), + $container->get('entity_type.bundle.info'), + $container->get('datetime.time') ); } diff --git a/tests/src/Functional/PdfWebformPopulationTest.php b/tests/src/Functional/PdfWebformPopulationTest.php index 7d80a1ebd2a5e4d34dbb028eac5683e35956279d..b29d24612d97414c71394d494dfacfcdd0f7a67f 100644 --- a/tests/src/Functional/PdfWebformPopulationTest.php +++ b/tests/src/Functional/PdfWebformPopulationTest.php @@ -42,7 +42,12 @@ class PdfWebformPopulationTest extends FillPdfTestBase { /** * {@inheritdoc} */ - protected function setUp() { + protected function setUp(): void { + // @todo: Stop skipping this test when Webform has Drupal 9 support. + if (version_compare('9.0.0', \Drupal::VERSION, '>=')) { + $this->markTestSkipped('Webform is not yet compatible with Drupal 9, so skipping these tests.'); + } + parent::setUp(); // Add some roles to this user.