From e48631b7b4619778d39a705216ab168fc41b2014 Mon Sep 17 00:00:00 2001
From: Kevin Kaland <kevin@wizone.solutions>
Date: Tue, 28 Apr 2020 22:02:54 +0200
Subject: [PATCH] Issue #3114541 by wizonesolutions: Remove useless check.
---
src/Service/FillPdfLinkManipulator.php | 4 ----
tests/src/Functional/LinkManipulatorTest.php | 3 ---
2 files changed, 7 deletions(-)
diff --git a/src/Service/FillPdfLinkManipulator.php b/src/Service/FillPdfLinkManipulator.php
index e39f3bc..da63f3e 100644
--- a/src/Service/FillPdfLinkManipulator.php
+++ b/src/Service/FillPdfLinkManipulator.php
@@ -61,10 +61,6 @@ class FillPdfLinkManipulator implements FillPdfLinkManipulatorInterface {
public function parseLink(Url $link) {
$query = $link->getOption('query');
- if (!$query) {
- throw new \InvalidArgumentException("This link doesn't specify a query string, so failing.");
- }
-
if (empty($query['fid'])) {
throw new \InvalidArgumentException('No FillPDF Form was specified in the query string, so failing.');
}
diff --git a/tests/src/Functional/LinkManipulatorTest.php b/tests/src/Functional/LinkManipulatorTest.php
index 8ed4027..62b8483 100644
--- a/tests/src/Functional/LinkManipulatorTest.php
+++ b/tests/src/Functional/LinkManipulatorTest.php
@@ -52,9 +52,6 @@ class LinkManipulatorTest extends BrowserTestBase {
// Hit the generation route with no query string set.
$fillpdf_route = Url::fromRoute('fillpdf.populate_pdf', [], []);
$this->drupalGet($fillpdf_route);
- // Ensure the exception is converted to an error and access is denied.
- $this->assertSession()->statusCodeEquals(403);
- $this->assertSession()->pageTextContains("This link doesn't specify a query string, so failing.");
// Hit the generation route with no fid set.
$fillpdf_route = Url::fromRoute('fillpdf.populate_pdf', [], [
--
GitLab