From e7025c7e4ae71118c80fb99765eee7e1422f61c6 Mon Sep 17 00:00:00 2001 From: Jason Davies Date: Sun, 15 Apr 2012 19:59:56 +0100 Subject: [PATCH] Update jsdom to v0.2.14. We can finally re-enable those tests! --- package.json | 2 +- src/package.js | 2 +- test/core/selection-html-test.js | 3 --- test/core/selection-text-test.js | 2 -- 4 files changed, 2 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index 430e5585..015de7fe 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ }, "main": "index.js", "dependencies": { - "jsdom": "0.2.12", + "jsdom": "0.2.14", "sizzle": "1.1.x" }, "devDependencies": { diff --git a/src/package.js b/src/package.js index 2533a5fe..c53f4c50 100644 --- a/src/package.js +++ b/src/package.js @@ -10,7 +10,7 @@ require("util").puts(JSON.stringify({ "repository": {"type": "git", "url": "http://github.com/mbostock/d3.git"}, "main": "index.js", "dependencies": { - "jsdom": "0.2.12", + "jsdom": "0.2.14", "sizzle": "1.1.x" }, "devDependencies": { diff --git a/test/core/selection-html-test.js b/test/core/selection-html-test.js index 4a470eca..9425273f 100644 --- a/test/core/selection-html-test.js +++ b/test/core/selection-html-test.js @@ -98,8 +98,6 @@ suite.addBatch({ assert.equal(div[0][1].lastChild.tagName, "I"); assert.equal(div[0][1].lastChild.textContent, "1"); }, - /* - https://github.com/tmpvar/jsdom/issues/276 "clears the inner HTML as null": function(div) { div.html(null); assert.equal(div[0][0].innerHTML, ""); @@ -107,7 +105,6 @@ suite.addBatch({ assert.equal(div[0][1].innerHTML, ""); assert.isNull(div[0][1].firstChild); }, - */ "clears the inner HTML as a function": function(div) { div.html(function() { return ""; }); assert.equal(div[0][0].innerHTML, ""); diff --git a/test/core/selection-text-test.js b/test/core/selection-text-test.js index c2c45cc4..687924ae 100644 --- a/test/core/selection-text-test.js +++ b/test/core/selection-text-test.js @@ -27,7 +27,6 @@ suite.addBatch({ assert.equal(document.body.textContent, "

Hello, world!

"); assert.equal(document.body.firstChild.nodeType, document.TEXT_NODE); }, - /* "clears the text content as null": function(body) { body.text(null); assert.equal(document.body.textContent, ""); @@ -44,7 +43,6 @@ suite.addBatch({ body.text(function() { return undefined; }); assert.equal(document.body.textContent, ""); }, - */ "ignores null nodes": function() { var body = d3.select("body"); body[0][0] = null; -- GitLab