1. 25 Oct, 2018 14 commits
  2. 24 Oct, 2018 2 commits
  3. 17 Jul, 2018 1 commit
  4. 05 Jul, 2018 1 commit
    • Benjamin Storer's avatar
      Refactor Science.cpp to split functions into separate files. · dffa6f21
      Benjamin Storer authored
      === Science ===
      The directory Science/ now contains files corresponding to
      the various functions in the now-removed Science.cpp.
      
      Filenames correspond directly with the function name, and each
      file contains only one functions, with a few notable exceptions.
       - Science/get_quads.cpp contains get_quads_x, get_quads_y, and get_quads_z
       - Science/compute_background_PE contains the helper function
      compare_pairs
      
      The global variables _quadw_x, _quadw_y, and _quadw_z are declared as
      extern in Science.hpp and declared in Science/compute_quadweights.cpp
      
      === Makefile ===
      The Makefile has been modified accordingly. It now automatically detects
      all Science/*.cpp files and includes them in the compile recipe.
      
      The Makefile has also been tidied up a little bit by defining a variable
      SPINS_BASE which points to the core files.
      dffa6f21
  5. 26 Apr, 2018 1 commit
  6. 25 Apr, 2018 2 commits
    • David Deepwell's avatar
      Update cases with mode-2 ISW · 0963fd7c
      David Deepwell authored
      Combined the mapped and unmapped cases for this into a single
      case file.
      0963fd7c
    • Christopher Subich's avatar
      Modify make_deps to check out libraries from UWGit · a55e544e
      Christopher Subich authored
      With the retirement of belize, which formerly hosted a fixed
      copy of the dependency libraries, make_deps.sh would no
      longer download and build said libraries.
      
      These libraries are now instead hosted in a dedicated
      repository at UWGit, so make_deps.sh has been changed to
      clone this repository.
      a55e544e
  7. 18 Apr, 2018 2 commits
  8. 05 Apr, 2018 1 commit
    • David Deepwell's avatar
      Update map_iwave case to use new diagnostics · e6b803fd
      David Deepwell authored
      This case has uncovered that the BPE calculation returns
      incorrect values when a Chebyshev grid is used on a field scale.
      The BPE calculation uses the quadrature weights as the volumes
      of each cell. This is true when the grid is regular, but incorrect
      for Chebyshev grids.
      
      To first approximation the Cheb quadrature weights are close to
      the volumes of the cells. This leads to the BPE calculation
      being accurate to 8 significant figures. 8 sig figs is not enough
      on fields scales since the magnitude of the PE can be very, very
      large. The difference of the BPE from the PE can thus be smaller
      than these 8 sig figs.
      e6b803fd
  9. 23 Mar, 2018 1 commit
  10. 22 Mar, 2018 1 commit
  11. 16 Mar, 2018 2 commits
  12. 13 Mar, 2018 1 commit
    • David Deepwell's avatar
      Update gravity_current to only use full zgrid · e938e1be
      David Deepwell authored
      The full xgrid and ygrid are unnecessary since x and y only
      depend on a single variable (or index - ii for x, and jj for y).
      The variables xx and yy can be used instead of xgrid and ygrid,
      respectively. Creating the full grids for these fields is a
      waste of memory.
      e938e1be
  13. 15 Feb, 2018 1 commit
  14. 09 Feb, 2018 1 commit
  15. 07 Feb, 2018 1 commit
    • Christopher Subich's avatar
      Simplify GMRES dot products; fix convergence errors · 8ae27fe5
      Christopher Subich authored
      This commit amends Cheb_2dmg::resid_dot (dot-product of
      residual vectors in the context of the 2D GMRES/multigrid
      iteration) to perform the dot-product in the simplest way,
      as a sum over grid elements.
      
      Before this, the code (which is left in the file but
      disabled by #if 1 / #else) tried to be clever and
      evenly-weight contributions from the interior, the boundary
      conditions, and the mean-pressure error (if the problem was
      indeterminate).  This evidently caused the long-standing
      problem of the GMRES inner iteration being far more
      optimistic about error (as reported by LAPACK) than would be
      computed by directly measuring the residual error.
      
      This problem was ultimately discovered when the
      doc_map_iwave case broke.  Even though this broken residual
      code has been in SPINS since before it was
      version-controlled via GIT, the map_iwave case would still
      converge (and relatively quickly) when the multigrid
      iteration had a relatively large coarse-solve size.
      
      Git bisect pinned the broken documentation case on the
      change that reduced the coase-grid size, which reduced the
      GMRES convergence rates enough that the errors caused by
      *this* problem broke convergence.
      
      Since this change replaces the error norm calculations used
      by GMRES, it should be treated with caution and mapped-grid
      cases should have a mark-1-eyeball inspection of results for
      a while.
      
      --
      
      Additionally, for debugging utility this change also
      includes crude residual/basis output for the 2D GMRES
      solver.  All current uses are commented out.
      8ae27fe5
  16. 30 Jan, 2018 1 commit
  17. 28 Jan, 2018 3 commits
  18. 25 Jan, 2018 1 commit
  19. 24 Jan, 2018 1 commit
  20. 10 Jan, 2018 2 commits