From 4de331dfb1cd44ab37128ef0a743d3d3efef24f8 Mon Sep 17 00:00:00 2001 From: ebremner Date: Thu, 21 Apr 2022 13:59:13 -0400 Subject: [PATCH 1/4] ISTWCMS-5500: updating rss in listing views to use correct variables --- .../04-components/view/view-interact/view-interact.twig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/_patterns/04-components/view/view-interact/view-interact.twig b/source/_patterns/04-components/view/view-interact/view-interact.twig index 4caba438..d5d70620 100644 --- a/source/_patterns/04-components/view/view-interact/view-interact.twig +++ b/source/_patterns/04-components/view/view-interact/view-interact.twig @@ -19,9 +19,9 @@ 'modifier_classes': 'icon--button', } %} {% endif %} - {% if rss_feed %} + {% if rss %} {% include '@components/icon/icon--button/icon--button.twig' with { - 'url': '#', + 'url': rss, 'text': 'rss', 'name': 'rss-box', 'is_hidden': false, -- GitLab From 012f43538784e8aa9e5bbc758d9cffadb5324307 Mon Sep 17 00:00:00 2001 From: Martin Leblanc Date: Thu, 21 Apr 2022 15:35:33 -0400 Subject: [PATCH 2/4] ISTWCMS-5500: swapping icon for rss to match dimensions and style of filters icon --- source/_patterns/04-components/svg/icons/_rss.svg.twig | 8 ++++++++ source/_patterns/04-components/svg/svgs.yml | 1 + .../04-components/view/view-interact/view-interact.twig | 2 +- 3 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 source/_patterns/04-components/svg/icons/_rss.svg.twig diff --git a/source/_patterns/04-components/svg/icons/_rss.svg.twig b/source/_patterns/04-components/svg/icons/_rss.svg.twig new file mode 100644 index 00000000..1a76ec71 --- /dev/null +++ b/source/_patterns/04-components/svg/icons/_rss.svg.twig @@ -0,0 +1,8 @@ + + + + diff --git a/source/_patterns/04-components/svg/svgs.yml b/source/_patterns/04-components/svg/svgs.yml index a4d9569c..e7f659b8 100644 --- a/source/_patterns/04-components/svg/svgs.yml +++ b/source/_patterns/04-components/svg/svgs.yml @@ -58,6 +58,7 @@ svg_names: - play - plus - podcast + - rss - rss-box - safari - search diff --git a/source/_patterns/04-components/view/view-interact/view-interact.twig b/source/_patterns/04-components/view/view-interact/view-interact.twig index d5d70620..0484a1c0 100644 --- a/source/_patterns/04-components/view/view-interact/view-interact.twig +++ b/source/_patterns/04-components/view/view-interact/view-interact.twig @@ -23,7 +23,7 @@ {% include '@components/icon/icon--button/icon--button.twig' with { 'url': rss, 'text': 'rss', - 'name': 'rss-box', + 'name': 'rss', 'is_hidden': false, 'modifier_classes': 'icon--button icon--rss', } %} -- GitLab From dda539a1c72047c09544c872068a9cb4a8e169a6 Mon Sep 17 00:00:00 2001 From: Martin Leblanc Date: Fri, 22 Apr 2022 12:09:45 -0400 Subject: [PATCH 3/4] ISTWCMS-5500: adding the capitalized RSS to the view interact and title in the svg --- source/_patterns/04-components/svg/icons/_rss.svg.twig | 1 + .../04-components/view/view-interact/view-interact.twig | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/source/_patterns/04-components/svg/icons/_rss.svg.twig b/source/_patterns/04-components/svg/icons/_rss.svg.twig index 1a76ec71..b6612ef3 100644 --- a/source/_patterns/04-components/svg/icons/_rss.svg.twig +++ b/source/_patterns/04-components/svg/icons/_rss.svg.twig @@ -1,5 +1,6 @@ +RSS