From 52cb238095046c52e403861f2666fff6d6603401 Mon Sep 17 00:00:00 2001
From: Kevin Paxman <kpaxman@uwaterloo.ca>
Date: Thu, 20 Mar 2025 09:55:29 -0400
Subject: [PATCH 1/2] ISTWCMS-7310: cookie banner a11y - make button be
described by text
---
.../eu-cookie-compliance/eu-cookie-compliance.twig | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/patterns/04-components/eu-cookie-compliance/eu-cookie-compliance.twig b/src/patterns/04-components/eu-cookie-compliance/eu-cookie-compliance.twig
index 2877a0f8..06f1fcc1 100644
--- a/src/patterns/04-components/eu-cookie-compliance/eu-cookie-compliance.twig
+++ b/src/patterns/04-components/eu-cookie-compliance/eu-cookie-compliance.twig
@@ -1,16 +1,18 @@
<div class="eu-cookie-compliance-banner eu-cookie-compliance-banner-info eu-cookie-compliance-banner--default">
<div class="popup-content info eu-cookie-compliance-content" role="alertdialog">
<div
- aria-labelledby="{{ cookie.labelledby_id }}"
- aria-describedby="{{ cookie.describedby_id }}"
id="popup-text"
- class="eu-cookie-compliance-message">
- <h2 id="{{ cookie.labelledby_id }}">{{ cookie.label }}</h2>
- <p id="{{ cookie.describedby_id }}">{{ cookie.description }}</p>
+ class="eu-cookie-compliance-message"
+ id="{{ cookie.describedby_id }}">
+ <h2>{{ cookie.label }}</h2>
+ <p>{{ cookie.description }}</p>
</div>
<div id="popup-buttons" class="eu-cookie-compliance-buttons">
- <button type="button" class="agree-button eu-cookie-compliance-default-button">{{ 'Accept all'|t }}</button>
+ <button type="button" class="agree-button eu-cookie-compliance-default-button"
+ aria-describedby="{{ cookie.describedby_id }}">
+ {{ 'Accept all'|t }}
+ </button>
</div>
</div>
</div>
--
GitLab
From 900f74f4cc5671f3a68db752107fa75f78483eff Mon Sep 17 00:00:00 2001
From: Kevin Paxman <kpaxman@uwaterloo.ca>
Date: Thu, 20 Mar 2025 10:27:02 -0400
Subject: [PATCH 2/2] ISTWCMS-7310: rebomve unused ID so our expected ID can be
the only ID attribute
---
.../04-components/eu-cookie-compliance/eu-cookie-compliance.twig | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/patterns/04-components/eu-cookie-compliance/eu-cookie-compliance.twig b/src/patterns/04-components/eu-cookie-compliance/eu-cookie-compliance.twig
index 06f1fcc1..0742853f 100644
--- a/src/patterns/04-components/eu-cookie-compliance/eu-cookie-compliance.twig
+++ b/src/patterns/04-components/eu-cookie-compliance/eu-cookie-compliance.twig
@@ -1,7 +1,6 @@
<div class="eu-cookie-compliance-banner eu-cookie-compliance-banner-info eu-cookie-compliance-banner--default">
<div class="popup-content info eu-cookie-compliance-content" role="alertdialog">
<div
- id="popup-text"
class="eu-cookie-compliance-message"
id="{{ cookie.describedby_id }}">
<h2>{{ cookie.label }}</h2>
--
GitLab