Commit af9fe7c4 authored by Alex Vandiver's avatar Alex Vandiver
Browse files

Stop hiding "Wide character in..." warnings

As input/output encoding has been cleaned up significantly, stop hiding
"Wide character in..." warnings, as they may conceal true problems.
parent 0a5fd0aa
......@@ -373,19 +373,9 @@ sub InitSignalHandlers {
## mechanism (see above).
$SIG{__WARN__} = sub {
# The 'wide character' warnings has to be silenced for now, at least
# until HTML::Mason offers a sane way to process both raw output and
# unicode strings.
# use 'goto &foo' syntax to hide ANON sub from stack
if( index($_[0], 'Wide character in ') != 0 ) {
unshift @_, $RT::Logger, qw(level warning message);
goto &Log::Dispatch::log;
}
# Return value is used only by RT::Test to filter warnings from
# reaching the Test::NoWarnings catcher. If Log::Dispatch::log() ever
# starts returning 'IGNORE', we'll need to switch to something more
# clever. I don't expect that to happen.
return 'IGNORE';
unshift @_, $RT::Logger, qw(level warning message);
goto &Log::Dispatch::log;
};
#When we call die, trap it and log->crit with the value of the die.
......
......@@ -685,12 +685,7 @@ sub __init_logging {
$filter = $SIG{__WARN__};
}
$SIG{__WARN__} = sub {
if ($filter) {
my $status = $filter->(@_);
if ($status and $status eq 'IGNORE') {
return; # pretend the bad dream never happened
}
}
$filter->(@_) if $filter;
# Avoid reporting this anonymous call frame as the source of the warning.
goto &$Test_NoWarnings_Catcher;
};
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment