Skip to content
Snippets Groups Projects
Commit 6153cfce authored by Earl Miles's avatar Earl Miles
Browse files

#361526 by jpetso: Fix some obvious untested bugs in the new API versioning code

parent 0479b3da
No related branches found
No related tags found
No related merge requests found
...@@ -43,13 +43,13 @@ function ctools_plugin_api_include($owner, $api, $minimum_version, $current_vers ...@@ -43,13 +43,13 @@ function ctools_plugin_api_include($owner, $api, $minimum_version, $current_vers
$cache[$owner][$api] = array(); $cache[$owner][$api] = array();
foreach (module_implements('ctools_plugin_api') as $module) { foreach (module_implements('ctools_plugin_api') as $module) {
$function = $module . '_ctools_plugin_api'; $function = $module . '_ctools_plugin_api';
$info = $function(); $info = $function($owner, $api);
if (!isset($info['version'])) { if (!isset($info['version'])) {
continue; continue;
} }
// Only process if version is between minimum and current, inclusive. // Only process if version is between minimum and current, inclusive.
if ($info['version'] >= $minimum_version && $info_version <= $current_version) { if ($info['version'] >= $minimum_version && $info['version'] <= $current_version) {
if (!isset($info['path'])) { if (!isset($info['path'])) {
$info['path'] = drupal_get_path('module', $module); $info['path'] = drupal_get_path('module', $module);
} }
...@@ -70,7 +70,7 @@ function ctools_plugin_api_include($owner, $api, $minimum_version, $current_vers ...@@ -70,7 +70,7 @@ function ctools_plugin_api_include($owner, $api, $minimum_version, $current_vers
} }
return $cache[$module][$api]; return $cache[$owner][$api];
} }
/** /**
...@@ -286,7 +286,7 @@ function ctools_plugin_process($info, $module, $identifier, $path, $file = NULL) ...@@ -286,7 +286,7 @@ function ctools_plugin_process($info, $module, $identifier, $path, $file = NULL)
); );
// Fill in plugin specific defaults, if they exist. // Fill in plugin specific defaults, if they exist.
if ($info['defaults']) { if (!empty($info['defaults'])) {
$result[$name] += $info['defaults']; $result[$name] += $info['defaults'];
} }
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment