Skip to content
Snippets Groups Projects
  • Kevin Kaland's avatar
    36fcef67
    Issue #2359213: Check access for private files. · 36fcef67
    Kevin Kaland authored
    A few things happened here. I split out the access-checking logic into a
    FillPdfAccessHelper service. In coordination with that, I added
    FillPdfLinkManipulator::parseUrlString() to facilitate parsing the
    context strings we store in FillPdfFileContext objects. I also changed
    the way I store URLs in FillPdfFileContext.context so that they are
    easier to pass to Url::fromUri() for parsing (and I made a helper
    method that parses them into a form Uri::fromUri() likes).
    
    In short, saving PDFs to files now works as well as downloading. Score!
    36fcef67
    History
    Issue #2359213: Check access for private files.
    Kevin Kaland authored
    A few things happened here. I split out the access-checking logic into a
    FillPdfAccessHelper service. In coordination with that, I added
    FillPdfLinkManipulator::parseUrlString() to facilitate parsing the
    context strings we store in FillPdfFileContext objects. I also changed
    the way I store URLs in FillPdfFileContext.context so that they are
    easier to pass to Url::fromUri() for parsing (and I made a helper
    method that parses them into a form Uri::fromUri() likes).
    
    In short, saving PDFs to files now works as well as downloading. Score!