Issue #2854452 by Znak: No correct hook_help() function

fillpdf.module

@@ -5,18 +5,26 @@
  * Allows mappings of PDFs to site content.
  */
 
+use Drupal\Core\Routing\RouteMatchInterface;
+
 /**
  * Implements hook_help().
  */
-function fillpdf_help($path, $arg) {
-  switch ($path) {
-    case 'admin/help#fillpdf':
-      $content = t('See the <a href="!documentation">documentation on drupal.org</a> for a full description of and guide to this module.', ['!documentation' => \Drupal\Core\Url::fromUri('http://drupal.org/documentation/modules/fillpdf')]);
+function fillpdf_help($route_name, RouteMatchInterface $route_match) {
+  switch ($route_name) {
+    case 'help.page.fillpdf':
+      $content = t('See the <a href=":documentation">documentation on drupal.org</a> for a full description of and guide to this module.', [
+        ':documentation' => \Drupal\Core\Url::fromUri('https://www.drupal.org/docs/8/modules/fillpdf')
+          ->toString(),
+      ]);
       return $content;
-    case 'admin/structure/fillpdf':
+    case 'fillpdf.forms_admin':
       if (\Drupal::moduleHandler()->moduleExists('help')) {
-        return t('See the !link for an explanation on dowloading these forms to PDF',
-          ['!link' => \Drupal::l(t('documentation'), \Drupal\Core\Url::fromUri('http://drupal.org/documentation/modules/fillpdf'))]);
+        return t('See the <a href=":link">documentation</a> for an explanation on dowloading these forms to PDF',
+          [
+            ':link' => \Drupal\Core\Url::fromUri('https://www.drupal.org/docs/8/modules/fillpdf')
+              ->toString(),
+          ]);
       }
       else {
         return t('Activate the help module if you need an explanation on downloading these forms to PDF.');