Skip to content
Snippets Groups Projects
Commit bd6babe7 authored by Liam Morland's avatar Liam Morland
Browse files

Coding standards

parent 3049718c
No related branches found
No related tags found
No related merge requests found
......@@ -19,8 +19,8 @@ abstract class FillPdfFormConfirmFormBase extends ContentEntityConfirmFormBase {
// @todo This is a workaround by webform for Core issue #2582295
// "Confirmation cancel links are incorrect if installed in a subdirectory".
// Remove after a fix landed there.
// See: https://www.drupal.org/project/drupal/issues/2582295
// See: https://www.drupal.org/project/webform/issues/2899166
// @see https://www.drupal.org/project/drupal/issues/2582295
// @see https://www.drupal.org/project/webform/issues/2899166
$request = $this->getRequest();
$destination = $request->query->get('destination');
if ($destination) {
......
......@@ -328,7 +328,7 @@ class FillPdfFormForm extends ContentEntityForm {
];
// @todo Check for empty value after Core issue is fixed.
// See: https://www.drupal.org/project/drupal/issues/1585930
// @see https://www.drupal.org/project/drupal/issues/1585930
$states_no_scheme = [
':input[name="scheme"]' => ['value' => '_none'],
];
......@@ -490,7 +490,7 @@ class FillPdfFormForm extends ContentEntityForm {
* {@inheritdoc}
*
* @todo Remove this (imperfect) workaround once the Core issue is fixed.
* See https://www.drupal.org/project/fillpdf/issues/3046178.
* @see https://www.drupal.org/project/fillpdf/issues/3046178
*/
protected function actions(array $form, FormStateInterface $form_state) {
$actions = parent::actions($form, $form_state);
......
......@@ -332,8 +332,8 @@ class FillPdfSettingsForm extends ConfigFormBase {
'#default_value' => $config->get('shell_locale') ?: 'en_US.utf8',
];
// @todo We're working around Core issue #2190333, resp. #2854166.
// Remove once one of these landed. See:
// https://www.drupal.org/project/drupal/issues/2854166.
// Remove once one of these landed.
// @see https://www.drupal.org/project/drupal/issues/2854166
$form['shell_locale']['#process'][] = [
'Drupal\Core\Render\Element\Select',
'processGroup',
......@@ -356,7 +356,7 @@ class FillPdfSettingsForm extends ConfigFormBase {
switch ($values['backend']) {
case 'fillpdf_service':
// @todo Add validation for FillPDF Service.
// See https://www.drupal.org/project/fillpdf/issues/3040899.
// @see https://www.drupal.org/project/fillpdf/issues/3040899
break;
case 'local_service':
......
......@@ -77,7 +77,7 @@ class TokenResolver implements TokenResolverInterface {
// Content may be marked as either 'text', 'image' or '' (= unknown).
// @todo Revisit when enforcing FillPdfFields to be one or the other.
// See: https://www.drupal.org/project/fillpdf/issues/3049368
// @see https://www.drupal.org/project/fillpdf/issues/3049368
$maybe_image = ($options['content'] !== 'text');
$maybe_text = ($options['content'] !== 'image');
......
......@@ -144,7 +144,7 @@ abstract class FillPdfUploadTestBase extends FillPdfTestBase {
$this->assertFileNotExists($new_file->getFileUri());
}
// @todo Simplify once Core bug gets fixed.
// See: https://www.drupal.org/project/drupal/issues/3043127.
// @see https://www.drupal.org/project/drupal/issues/3043127
$this->assertFileEntryNotExists($new_file, NULL);
break;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment