Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L libfibre
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Martin Karsten
  • libfibre
  • Merge requests
  • !1

Timer vs Unblocking Race Simplification

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Matthew James Cameron May requested to merge mjcmay/libfibre:timer-improvements into master Feb 01, 2021
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 4

Move the responsibility of figuring out who won the resume race to after Fibre resumption.

Caveats

  • Since resume may now be called more than once, changed the runState logic to ensure that resume() is idempotent.
  • To avoid iterator invalidation issues if "erase" is called after the timer fires, change the timer queue to store BaseTimer pointers
  • TimerQueue::erase() now blocks if the timer is currently firing to avoid segfault issues.
  • Use doubly linked list (intrusive) instead of std::list for fireList so that timers can be erased from it
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: timer-improvements