Coding standards

README.md

@@ -10,4 +10,5 @@ Run:
 imageMagick 8.x-2.x-beta1-uw_wcms
 
 * Base: 8.x-2.0-beta1
-* Patch 60b739: Fix Animated GIF resizing. https://www.drupal.org/node/1802534#comment-12246133
+* Patch 60b739: Fix Animated GIF resizing.
+https://www.drupal.org/node/1802534#comment-12246133

drupal-settings.php

 <?php
 
-// Show all errors on most servers. On live, these are turned off in host_settings.php.
+/**
+ * @file
+ * Settings common to all sites.
+ */
+
+// Show all errors on most servers. On live, these are turned off in
+// host_settings.php.
 $conf['error_level'] = 2;
 
 foreach (['db', 'host', 'network', 'cache', 'password'] as $file) {
-  $file_path = DRUPAL_ROOT . '/config/' . $file. '_settings.php';
+  $file_path = DRUPAL_ROOT . '/config/' . $file . '_settings.php';
   if (file_exists($file_path)) {
-    require_once($file_path);
+    require_once $file_path;
   }
 }
 unset($file);
@@ -54,7 +60,8 @@ $conf['date_format_medium'] = 'D, Y-m-d H:i';
 $conf['date_format_news_short'] = 'M j Y';
 $conf['date_format_time_only'] = 'g:ia';
 
-// Disable user picture support and set the default to a square thumbnail option in case it is enabled later.
+// Disable user picture support and set the default to a square
+// thumbnail option in case it is enabled later.
 $conf['user_pictures'] = '0';
 $conf['user_picture_dimensions'] = '1024x1024';
 $conf['user_picture_file_size'] = '800';
@@ -62,7 +69,9 @@ $conf['user_picture_style'] = 'thumbnail';
 
 // Other.
 $conf['shortcut_max_slots'] = 12;
-$conf['user_register'] = 0; // Same value as constant USER_REGISTER_ADMINISTRATORS_ONLY. Constant not yet defined.
+// Same value as constant USER_REGISTER_ADMINISTRATORS_ONLY. Constant
+// not yet defined.
+$conf['user_register'] = 0;
 $conf['scheduler_publisher_user'] = 'specific_user';
 $conf['scheduler_date_popup_minute_increment'] = 15;
 $conf['update_check_disabled'] = TRUE;

uw_base_profile.info.yml

 name: UW base profile
 type: profile
 description: 'A copy of the standard install with some presets configured.'
-version: 1.0
 core: 8.x
 dependencies:
   - block_content

uw_base_profile.profile

@@ -5,7 +5,6 @@
  * Enables modules and site configuration for a standard site installation.
  */
 
-use Drupal\contact\Entity\ContactForm;
 use Drupal\Core\Form\FormStateInterface;
 
 /**
@@ -14,15 +13,15 @@ use Drupal\Core\Form\FormStateInterface;
  * Allows the profile to alter the site configuration form.
  */
 function uw_base_profile_form_install_configure_form_alter(&$form, FormStateInterface $form_state) {
-  // Account information defaults
+  // Account information defaults.
   $form['admin_account']['account']['name']['#default_value'] = 'wcmsadmin';
   $form['site_information']['site_mail']['#default_value'] = 'wcmsadmin@uwaterloo.ca';
   $form['admin_account']['account']['mail']['#default_value'] = 'wcmsadmin@uwaterloo.ca';
 
-  // Date/time settings
+  // Date/time settings.
   $form['regional_settings']['site_default_country']['#default_value'] = 'CA';
   $form['regional_settings']['date_default_timezone']['#default_value'] = 'America/Toronto';
 
-  // Update notification defaults
+  // Update notification defaults.
   $form['update_notifications']['enable_update_status_emails']['#default_value'] = 0;
 }