Skip to content
Snippets Groups Projects
  1. Jan 27, 2014
  2. Jan 08, 2014
  3. Sep 10, 2013
  4. Sep 05, 2013
    • Ruslan Zakirov's avatar
      don't override _RecordCount · 9a7fa566
      Ruslan Zakirov authored
      This caused not merged users at the end of the collection
      to be skipped.
      
      _RecordCount is used in SB's Next to stop the iterator.
      If we change return value, but don't change storage then
      iterator stops earlier.
      9a7fa566
  5. Aug 02, 2013
  6. Jun 26, 2013
  7. Jun 10, 2013
  8. May 07, 2013
    • Thomas Sibley's avatar
      Always lookup effective ids on RT::User · 20fbf53c
      Thomas Sibley authored
      This allows merged users to be properly picked up when loaded via an
      RT::CurrentUser object, such as during login.
      
      An equivalent core change, on 4.0/currentuser-attributes, is also
      necessary to prevent inconsistency.
      20fbf53c
  9. Mar 12, 2013
  10. Feb 27, 2013
    • Alex Vandiver's avatar
      Ensure that $canonical_self, when inspected, still has unmerged data · b13c4340
      Alex Vandiver authored
      $canonical_self->SetComments() calls a $self->Load( $self->id ) during
      the process of updating the Comments.  Because this now loads the data
      of the user we are merged into, the information recorded on $merged was
      always contentless -- namely, it always showed the the user had been
      merged into itself.
      
      Swap the order of the ->SetComments calls, to ensure that
      $canonical_self is still the user being merged in when it is inspected
      to record data on $merge.
      b13c4340
    • Alex Vandiver's avatar
      Explicitly checking EffectiveId is also unneeded in CanonicalizeEmailAddress · 9f9da780
      Alex Vandiver authored
      As CanonicalizeEmailAddress uses ->LoadByCols to look up the email
      address, and we override LoadByCols to chase EffectiveId after a
      successful LoadByCols call, looking up EffectiveId again is unnecessary.
      
      The recursive call is kept, on the possibility that
      CanonicalizeEmailAddressMatch will match the _new_, canonicalized form.
      This preserves the previous behavior.
      9f9da780
    • Alex Vandiver's avatar
      Explicitly canonicalizing both $merged and $canonical_self is not required · 569bd681
      Alex Vandiver authored
      As the path to get both user objects uses ->Load, which calls
      ->LoadByCols, which we have overridden, we already have the most
      canonical form.  Checking it for EffectiveId is unnecessary and
      wasteful.
      569bd681
  11. Feb 25, 2013
  12. Aug 30, 2012
  13. Oct 17, 2011
  14. Sep 26, 2011
  15. Dec 14, 2010
  16. Jun 07, 2010
  17. Jun 04, 2010
  18. Oct 02, 2009
  19. Sep 16, 2009
  20. Apr 09, 2009
  21. Apr 07, 2009
  22. Nov 23, 2008
Loading