- Jan 27, 2014
-
-
Alex Vandiver authored
-
- Jan 08, 2014
-
-
Alex Vandiver authored
This allows the Creator of the EffectiveId to serve as a signal as to who merged the users
-
- Sep 10, 2013
-
-
Ruslan Zakirov authored
-
- Sep 05, 2013
-
-
Ruslan Zakirov authored
This caused not merged users at the end of the collection to be skipped. _RecordCount is used in SB's Next to stop the iterator. If we change return value, but don't change storage then iterator stops earlier.
-
- Aug 02, 2013
-
-
Thomas Sibley authored
-
- Jun 26, 2013
-
-
Alex Vandiver authored
-
- Jun 10, 2013
-
-
Alex Vandiver authored
-
Alex Vandiver authored
Failure to do so would cause the following to fail: my $id = $users->First->id; $users->GotoFirstItem; is( $id, $users->First->id ); ...as the firt user would have been marked "already seen" and thus would be ignored on successive iterations through the collection.
-
- May 07, 2013
-
-
Thomas Sibley authored
This allows merged users to be properly picked up when loaded via an RT::CurrentUser object, such as during login. An equivalent core change, on 4.0/currentuser-attributes, is also necessary to prevent inconsistency.
-
- Mar 12, 2013
-
-
Alex Vandiver authored
Hook::LexWrap is unnecessary: the wrapping being done was not lexical, and it was not being used for its abilities to alter return or argument values. Remove it, as using it anywhere causes _all_ stack traces to lack argument values at all levels of the stacktrace.
-
- Feb 27, 2013
-
-
Alex Vandiver authored
$canonical_self->SetComments() calls a $self->Load( $self->id ) during the process of updating the Comments. Because this now loads the data of the user we are merged into, the information recorded on $merged was always contentless -- namely, it always showed the the user had been merged into itself. Swap the order of the ->SetComments calls, to ensure that $canonical_self is still the user being merged in when it is inspected to record data on $merge.
-
Alex Vandiver authored
As CanonicalizeEmailAddress uses ->LoadByCols to look up the email address, and we override LoadByCols to chase EffectiveId after a successful LoadByCols call, looking up EffectiveId again is unnecessary. The recursive call is kept, on the possibility that CanonicalizeEmailAddressMatch will match the _new_, canonicalized form. This preserves the previous behavior.
-
Alex Vandiver authored
As the path to get both user objects uses ->Load, which calls ->LoadByCols, which we have overridden, we already have the most canonical form. Checking it for EffectiveId is unnecessary and wasteful.
-
- Feb 25, 2013
-
-
Thomas Sibley authored
-
Alex Vandiver authored
This avoids uninitialized in concatenation warnings and is more useful than a blank in user comments.
-
Thomas Sibley authored
RT doesn't support undef → NULL conversion yet, and everything in RT expects a defined value. The empty string is the canonical "no email address" value. In the future once RT moves to real NULLs, we can revert this commit.
-
- Aug 30, 2012
-
-
sunnavy authored
it could make email validation always pass, see also #70641 on rt.cpan use list context instead to get the right return value.
- Oct 17, 2011
-
-
Thomas Sibley authored
-
Thomas Sibley authored
Otherwise you can't run through a collection more than once.
-
- Sep 26, 2011
-
-
Kevin Falcone authored
-
- Dec 14, 2010
-
-
Kevin Falcone authored
-
- Jun 07, 2010
-
-
Ruslan Zakirov authored
-
Ruslan Zakirov authored
-
- Jun 04, 2010
-
-
Ruslan Zakirov authored
* new M::I * README -> POD -> README * makefile cleanup -> POD
-
- Oct 02, 2009
-
-
Kevin Falcone authored
-
Kevin Falcone authored
mimics some of the behavior of 3.8's new user display even on 3.6 Based on proposed patch from Jason A Smith
-
Kevin Falcone authored
-
Kevin Falcone authored
-
- Sep 16, 2009
-
-
Kevin Falcone authored
-
- Apr 09, 2009
-
-
Kevin Falcone authored
-
- Apr 07, 2009
-
-
Kevin Falcone authored
-
Kevin Falcone authored
-
- Nov 23, 2008
-
-
Kevin Falcone authored
-
Kevin Falcone authored
-