Skip to content
Snippets Groups Projects

Shea occlusion manager

Merged Shea Anthony Cardozo requested to merge shea-occlusion-manager into dev
All threads resolved!

This PR compromises the version 1 of the occlusion manager, focusing on masking the SimulationHistoryBuffer input to the ego planner based on some rule.

It also contains a number of misc changes to support visualizing occlusions. I think checking out test_notebook.ipynb is the best way of intuiting how to run things. Let me know if there are any questions.

Merge request reports

Approved by

Merged by Eli Henry DykhneEli Henry Dykhne 1 year ago (Nov 28, 2023 10:55pm UTC)

Merge details

  • Changes merged into dev with 8f553312.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Eli Henry Dykhne
  • Eli Henry Dykhne
  • Looks very good. I'll merge this into dev as soon as you address the comments.

  • Eli Henry Dykhne requested review from @j5riddel and removed review request for @ehdykhne

    requested review from @j5riddel and removed review request for @ehdykhne

  • Eli Henry Dykhne requested review from @ehdykhne and removed review request for @j5riddel

    requested review from @ehdykhne and removed review request for @j5riddel

  • added 5 commits

    • 0ea753cc - occlusion manager changes
    • 3b7fad68 - moving test_notebook
    • b626ed86 - More Occlusion Manager Changes
    • a3530f1a - changing how occlusion masks are saved in history
    • de0654aa - remaining documentation

    Compare with previous version

  • Shea Anthony Cardozo resolved all threads

    resolved all threads

  • Thanks for the review @ehdykhne ! All issues should be addressed.

  • Eli Henry Dykhne approved this merge request

    approved this merge request

  • Eli Henry Dykhne marked this merge request as ready

    marked this merge request as ready

  • Eli Henry Dykhne mentioned in commit 8f553312

    mentioned in commit 8f553312

  • Please register or sign in to reply
    Loading